fix driver optoe twoaddr a2h read write bug#435
Open
songqh2022 wants to merge 1 commit intosonic-net:202211from
Open
fix driver optoe twoaddr a2h read write bug#435songqh2022 wants to merge 1 commit intosonic-net:202211from
songqh2022 wants to merge 1 commit intosonic-net:202211from
Conversation
Author
|
@paulmenzel Could you kindly help to review this request(202211 branch)? thank you very much! |
Author
|
@saiarcot895 @paulmenzel @donboll Could you kindly help to review this request? |
Contributor
|
Let’s first get #434 reviewed and submitted. |
Signed-off-by: Qinghua Song <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page select register(127) only in the a0h from sfp8472 spec, so when access the a2h , the function optoe_translate_offset will update the slave_addr=a2h, and then using this slave_addr to config the page slelect register, so the contents is wrong.